Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 7.4.1 #11377

Merged
merged 3 commits into from Sep 2, 2023
Merged

Prepare release 7.4.1 #11377

merged 3 commits into from Sep 2, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 2, 2023

Created automatically from manual trigger.

Once all builds pass and it has been approved by one or more maintainers, the build
can be released by pushing a tag 7.4.1 to this repository.

@nicoddemus
Copy link
Member

As commented in #11126 (comment), I'm also including some improvements to our CI workflow:

  • Build the package only once, and test on all platforms.
  • Deploy is now triggered manually via an Action, which is then responsible for tagging the repository after the package has been uploaded successfully.

This new workflow has been used successfully already in pytest-mock and pytest-xdist.

Once this is merged, I will port the workflow back to main (seems easier to test and make sure it is working here during a release, rather than implementing this on main and then backporting).

@nicoddemus nicoddemus force-pushed the release-7.4.1 branch 3 times, most recently from bc11330 to dde5825 Compare September 2, 2023 11:34
* Build the package only once, and test on all platforms.
* Deploy is now triggered manually via an Action, which is then responsible for tagging the repository after the package has been uploaded successfully.
* Drop 'docs': we nowadays rely on readthedocs preview PR builds.
@nicoddemus nicoddemus mentioned this pull request Sep 2, 2023
@nicoddemus
Copy link
Member

Waiting on #11378 in order to be able to trigger deploy (because of workflow_dispatch, which needs to land on main first).

@nicoddemus
Copy link
Member

Now that #11378 was merged, I triggered the deploy workflow; it is now sitting there waiting approval. @bluetech would you like to do the honors?

@bluetech
Copy link
Member

bluetech commented Sep 2, 2023

Seems like it was published, only the tag push failed.

@nicoddemus
Copy link
Member

Seems like it was published, only the tag push failed.

Yes, bummer. I pushed the tag manually, and will commit a fix to that problem.

We need the checked out repository in order to push the tag.
@nicoddemus nicoddemus merged commit 82eb86f into 7.4.x Sep 2, 2023
24 of 25 checks passed
@nicoddemus nicoddemus deleted the release-7.4.1 branch September 2, 2023 15:41
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 2, 2023
Prepare release 7.4.1

(cherry picked from commit 82eb86f)
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 2, 2023
Prepare release 7.4.1

(cherry picked from commit 82eb86f)
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 2, 2023
Prepare release 7.4.1

(cherry picked from commit 82eb86f)
nicoddemus added a commit that referenced this pull request Sep 2, 2023
Merge pull request #11377 from pytest-dev/release-7.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants