Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explain --last-failed-no-failures in docs #11354

Closed
nicoddemus opened this issue Aug 26, 2023 · 10 comments · Fixed by #11361
Closed

Better explain --last-failed-no-failures in docs #11354

nicoddemus opened this issue Aug 26, 2023 · 10 comments · Fixed by #11361
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification

Comments

@nicoddemus
Copy link
Member

nicoddemus commented Aug 26, 2023

As discussed in #11346 (comment), the feature could be made clearer in the docs:

https://docs.pytest.org/en/stable/how-to/cache.html#behavior-when-no-tests-failed-in-the-last-run

@nicoddemus nicoddemus added type: docs documentation improvement, missing or needing clarification good first issue easy issue that is friendly to new contributor labels Aug 26, 2023
@seanjedi
Copy link
Contributor

I can work on this if that is ok

@seanjedi
Copy link
Contributor

seanjedi commented Aug 26, 2023

@nicoddemus
Made a PR here: #11357
Pre-commit may fail cause of these two issues:

Feel free to let me know if I should make any edits or changes

@nicoddemus
Copy link
Member Author

Hi @seanjedi, as I commented in the PR, the idea is to change the documentation, not the command-line help message. Would appreciate if you give this another go!

@DetachHead
Copy link
Contributor

why not update both?

@nicoddemus
Copy link
Member Author

If we can improve on both certainly!

@seanjedi
Copy link
Contributor

@nicoddemus
As per request from DetachHead, I have updated both and created a PR here: #11361
Let me know if I should make any other changes or improvements, or if my update is too lengthy.

@seanjedi
Copy link
Contributor

@nicoddemus Thanks for the feedback on the PR.
I have updated my changes as of this commit: 75e815f
Feel free to let me know if you have any concerns or changes that I should make.

@nicoddemus
Copy link
Member Author

@seanjedi thanks for the heads up, but there's no need for that, GitHub already notifies me of your new commits to the PR. 😁

@seanjedi
Copy link
Contributor

Ohh whoops lol, thanks for letting me know!

@nicoddemus
Copy link
Member Author

Sure thing!

nicoddemus pushed a commit that referenced this issue Aug 29, 2023
Improve documentation for last-failed-no-failures to make the different options and the functionality more clear.

Closes #11354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Projects
None yet
3 participants