Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox: PYTHONWARNDEFAULTENCODING should only be applied to tests #11157

Closed
bluetech opened this issue Jul 1, 2023 · 2 comments · Fixed by #11173
Closed

tox: PYTHONWARNDEFAULTENCODING should only be applied to tests #11157

bluetech opened this issue Jul 1, 2023 · 2 comments · Fixed by #11173
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@bluetech
Copy link
Member

bluetech commented Jul 1, 2023

Currently PYTHONWARNDEFAULTENCODING is set for all tox environments. But most tools like pre-commit, mypy, sphinx are not clean of this warning, it causes noise when running tox, in some cases a lot of noise.

I tried fixing it myself but couldn't figure out how to get tox to only set an envvar only for the py* environments. Hopefully someone who knows more about tox can figure it out.
@bluetech bluetech added the type: infrastructure improvement to development/releases/CI structure label Jul 1, 2023
@Zac-HD
Copy link
Member

Zac-HD commented Jul 4, 2023

I just add a setenv = section to the environments where I want to set it back to zero; see HypothesisWorks/hypothesis#3691 for an example. I've also opened a bunch of issues and PRs asking upstream projects to run clean themselves, so hopefully it'll get easier over time.

bluetech added a commit to bluetech/pytest that referenced this issue Jul 5, 2023
@bluetech
tox: turn off PYTHONWARNDEFAULTENCODING for pre-commit, sphinx etc.
119cec0 
Fix pytest-dev#11157.
@bluetech bluetech mentioned this issue Jul 5, 2023
Merged
@bluetech
Copy link
Member Author

bluetech commented Jul 5, 2023

@Zac-HD this works, sent #11173 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tox: turn off PYTHONWARNDEFAULTENCODING for pre-commit, sphinx etc. bluetech/pytest
2 participants
@bluetech @Zac-HD