Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include reason in cache path warnings #11005

Merged
merged 1 commit into from May 18, 2023
Merged

Include reason in cache path warnings #11005

merged 1 commit into from May 18, 2023

Conversation

scop
Copy link
Contributor

@scop scop commented May 15, 2023 •
edited

To aid debugging.

@scop scop force-pushed the chore/cache-path-why-could-not branch 2 times, most recently from 11e7f0a to 18c6488 Compare May 15, 2023 07:55
nicoddemus
nicoddemus requested changes May 15, 2023
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a trivial changelog entry? Thanks!

src/_pytest/cacheprovider.py Outdated Show resolved Hide resolved
src/_pytest/cacheprovider.py Outdated Show resolved Hide resolved
@scop @nicoddemus
Include reason in cache path warnings to aid debugging
38a2364 
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@scop scop force-pushed the chore/cache-path-why-could-not branch from 3282995 to 38a2364 Compare May 18, 2023 07:32
@scop
Copy link
Contributor Author

scop commented May 18, 2023

Done.

@nicoddemus
Copy link
Member

Thanks, appreciate it!

@nicoddemus nicoddemus merged commit c8641f8 into pytest-dev:main May 18, 2023
24 of 25 checks passed
@github-actions github-actions bot mentioned this pull request May 18, 2023
Closed
@scop scop deleted the chore/cache-path-why-could-not branch May 18, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scop @nicoddemus