Enable PYTHONWARNDEFAULTENCODING=1 and fix violations
#10935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
requested changes
Apr 25, 2023
Zac-HD
changed the title
PYTHONWARNDEFAULTENCODING=1 and fix violations
Zac-HD
force-pushed
the
10328
branch
6 times, most recently
from
3c6606e
to
fa9c498
Compare
bluetech
approved these changes
Jun 21, 2023
The-Compiler
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Amazing work, thanks @Zac-HD and @nondescryptid! I noticed a couple of small things, but I agree we should aim to merge this quickly (and I'm looking forward to turning this warning on for my own project finally!).
Zac-HD
force-pushed
the
10328
branch
2 times, most recently
from
8841734
to
f6b995e
Compare
The-Compiler
approved these changes
Jun 21, 2023
5 tasks
|
Oh my goodness. @The-Compiler So sorry about not responding earlier to your request for changes. I didn't receive notifications for this and only realised this had been merged when I was looking through my account's commit history and wondered why I had a commit to pytest. Massive thanks to you, @bluetech and @Zac-HD! |
|
All good, no worries! We got it all merged, and it still was a good starting point :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated attempt to check encoding warnings as in #10328, as dependencies have been updated in the past 6 months.
(Zac edit: now also fixes #7781)