Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pytest-dev/pytest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.2.2
Choose a base ref
...
head repository: pytest-dev/pytest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.2.3
Choose a head ref
  • 9 commits
  • 11 files changed
  • 3 contributors

Commits on Jan 25, 2021

  1. Merge pull request #8275 from pytest-dev/release-6.2.2

    Prepare release 6.2.2
    nicoddemus authored Jan 25, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    IvanGoncharov Ivan Goncharov
    Copy the full SHA
    8220eca View commit details

Commits on Jan 27, 2021

  1. Merge pull request #8280 from xuhdev/module

    Doc: Move the module declaration to index.rst
    nicoddemus committed Jan 27, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    56e4392 View commit details
  2. Merge pull request #8285 from nicoddemus/backport-8280

    [6.2.x] Doc: Move the module declaration to index.rst
    nicoddemus authored Jan 27, 2021
    Copy the full SHA
    12e7db8 View commit details

Commits on Apr 3, 2021

  1. Copy the full SHA
    02fdbe2 View commit details
  2. pathlib: inline ensure_reset_dir()

    This is only used in TempPathFactory.getbasetemp(). We'll be wanting
    further control/care there, so move it into there.
    bluetech committed Apr 3, 2021
    Copy the full SHA
    93dbae2 View commit details
  3. tmpdir: fix temporary directories created with world-readable permiss…

    …ions
    
    (Written for a Unix system, but might be applicable to Windows as well).
    
    pytest creates a root temporary directory under /tmp, named
    `pytest-of-<username>`, and creates tmp_path's and other under it.
    /tmp is shared between all users of the system.
    
    This root temporary directory was created with 0o777&~umask permissions,
    which usually becomes 0o755, meaning any user in the system could list
    and read the files, which is undesirable.
    
    Use 0o700 permissions instead. Also for subdirectories, because the root
    dir is adjustable.
    bluetech committed Apr 3, 2021
    Copy the full SHA
    9dc54f7 View commit details
  4. tmpdir: prevent using a non-private root temp directory

    pytest uses a root temp directory named `/tmp/pytest-of-<username>`. The
    name is predictable, and the directory might already exists from a
    previous run, so that's allowed.
    
    This makes it possible for my_user to pre-create
    `/tmp/pytest-of-another_user`, thus giving my_user control of
    another_user's tempdir.
    
    Prevent this scenario by adding a couple of safety checks. I believe
    they are sufficient.
    
    Testing the first check requires changing the owner, which requires
    root permissions, so can't be unit-tested easily, but I checked it
    manually.
    bluetech committed Apr 3, 2021
    Copy the full SHA
    822686e View commit details
  5. Merge pull request #8517 from bluetech/backport-mktmp

    [6.2.x] Fix minor temporary directory security issue
    bluetech authored Apr 3, 2021
    Copy the full SHA
    138b19a View commit details
  6. Copy the full SHA
    3a2fd96 View commit details
Loading