From 18c6488a932555750d8627e999db90c0d92fbc39 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Skytt=C3=A4?= <ville.skytta@iki.fi>
Date: Mon, 15 May 2023 10:15:33 +0300
Subject: [PATCH] Include reason in cache path warnings to aid debugging

---
 src/_pytest/cacheprovider.py  | 18 ++++++++++++++----
 testing/test_cacheprovider.py |  2 +-
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/src/_pytest/cacheprovider.py b/src/_pytest/cacheprovider.py
index 719b32f7e0e..8b29e7cb328 100755
--- a/src/_pytest/cacheprovider.py
+++ b/src/_pytest/cacheprovider.py
@@ -179,16 +179,26 @@ def set(self, key: str, value: object) -> None:
             else:
                 cache_dir_exists_already = self._cachedir.exists()
                 path.parent.mkdir(exist_ok=True, parents=True)
-        except OSError:
-            self.warn("could not create cache path {path}", path=path, _ispytest=True)
+        except OSError as exc:
+            self.warn(
+                "could not create cache path {path}: {exc}",
+                path=path,
+                exc=exc,
+                _ispytest=True,
+            )
             return
         if not cache_dir_exists_already:
             self._ensure_supporting_files()
         data = json.dumps(value, ensure_ascii=False, indent=2)
         try:
             f = path.open("w", encoding="UTF-8")
-        except OSError:
-            self.warn("cache could not write path {path}", path=path, _ispytest=True)
+        except OSError as exc:
+            self.warn(
+                "cache could not write path {path}: {exc}",
+                path=path,
+                exc=exc,
+                _ispytest=True,
+            )
         else:
             with f:
                 f.write(data)
diff --git a/testing/test_cacheprovider.py b/testing/test_cacheprovider.py
index 2f8517f9962..ee2fe1845df 100644
--- a/testing/test_cacheprovider.py
+++ b/testing/test_cacheprovider.py
@@ -87,7 +87,7 @@ def test_cache_failure_warns(
                 "*= warnings summary =*",
                 "*/cacheprovider.py:*",
                 "  */cacheprovider.py:*: PytestCacheWarning: could not create cache path "
-                f"{unwritable_cache_dir}/v/cache/nodeids",
+                f"{unwritable_cache_dir}/v/cache/nodeids: *",
                 '    config.cache.set("cache/nodeids", sorted(self.cached_nodeids))',
                 "*1 failed, 3 warnings in*",
             ]