Deploy via a protected environment and using PyPI trusted publishers #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following recent discussions, this changes the development process as follows: 1. The deploy is now manually triggered after the release PR is approved. 2. The deploy workflow tags the repository only after the package has been published to PyPI. 3. Use PyPI trusted publishers instead of API tokens.
bluetech
approved these changes
May 10, 2023
Besides being more secure, as it does not need special permissions, it is also safer as we can manually download and inspect the package.
|
Done! Good idea -- besides being more secure, as it does not need special permissions, it is also safer as we can manually download and inspect the package. |
bluetech
reviewed
May 11, 2023
Co-authored-by: Ran Benita <ran@unusedvar.com>
RonnyPfannschmidt
approved these changes
May 12, 2023
|
@RonnyPfannschmidt did you see my comment at the bottom of the PR description? Should I go ahead with that, or would you like to test something regarding the new PyPI pytest-dev org? |
|
Go ahead with the config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent discussions, this changes the development process as follows:
After this gets merged, I plan to configure the environment in the repository settings, and enable trusted publishing on PyPI (-- or not, @RonnyPfannschmidt might know more about the status of PyPI organizations for deployment).