-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support for File and Service modules #683
Conversation
@philpep feel free to have a look at the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.
Thanks for your comments @philpep . I would get back to them asap! |
…into windows-file-service
Hey @philpep . Just to let you know that I addressed your review comments. Thanks for having a look! |
Merged, thanks! |
Opened a new PR for adding Windows support for File and Service modules in Testinfra as the old one #532 has been inactive for quite some time. The PR contains all the changes in #532 and a few more implementations.
Please let me know of any comments.