Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support for File and Service modules #683

Merged
merged 3 commits into from
May 20, 2023

Conversation

tdas3001
Copy link
Contributor

Opened a new PR for adding Windows support for File and Service modules in Testinfra as the old one #532 has been inactive for quite some time. The PR contains all the changes in #532 and a few more implementations.

# Basic file and service operations are now supported in windows remote server
>>> host.file("C:/Users/Administrator/pytest-testinfra").is_directory
True
>>> host.file("C:/Users/Administrator/pytest-testinfra/images").listdir()
['alphine', 'archlinux', 'debian_bullseye', 'rockylinux8', 'ubuntu_xenial']

Please let me know of any comments.

@tdas3001
Copy link
Contributor Author

@philpep feel free to have a look at the PR

Copy link
Contributor

@philpep philpep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.

@tdas3001
Copy link
Contributor Author

Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.

Thanks for your comments @philpep . I would get back to them asap!

@tdas3001
Copy link
Contributor Author

Thanks! Like I said in some other PR, I don't have knowledge neither time to maintain this. However this PR looks almost reasonable, so if other windows user can test this and tell me it's useful for them, I'll be happy to merge it.

Thanks for your comments @philpep . I would get back to them asap!

Hey @philpep . Just to let you know that I addressed your review comments. Thanks for having a look!

@philpep philpep merged commit 8520850 into pytest-dev:main May 20, 2023
@philpep
Copy link
Contributor

philpep commented May 20, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants