Fix crash with setup errors and --rerun-except flag #244
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joonalai
force-pushed
the
fix-setup-crash
branch
from
98926ed to
fa56409
Compare
icemac
approved these changes
Nov 22, 2023
If an error occurs that early probably rerunning does not help, but this could be solved in another PR. |
I agree, maybe another issue or PR should be opened for this. |
icemac
requested changes
Nov 22, 2023
icemac
approved these changes
Nov 22, 2023
|
Thank you for this PR. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes internal errors on setup (non-existent fixtures etc) that occur when using --rerun-except flag.
I am wondering whether reruns should occur when failure happens on setup part of the test?