-
Notifications
You must be signed in to change notification settings - Fork 346
Add support for Django 5.2 #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I’m a bit confused about what entries we include on the testing matrix, so I just added a few that I thought would make sense.
That's what I do :)
Okay, fair. Maybe we can find some way to make it smarter in the future. One possible optimization, which I use in my projects, is to put all Python and DB versions in a matrix, and run tests for all matching Django versions. It’s much faster to rerun a bunch of tests than spin up a new GitHub Actions worker. |
Bumps [pytest-django](https://github.com/pytest-dev/pytest-django) from 4.9.0 to 4.11.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-django/releases">pytest-django's releases</a>.</em></p> <blockquote> <h2>v4.11.1</h2> <p><a href="https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4111-2025-04-03">https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4111-2025-04-03</a></p> <h2>v4.11.0</h2> <p><a href="https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4110-2025-04-01">https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4110-2025-04-01</a></p> <h2>v4.10.0</h2> <p><a href="https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4100-2025-02-10">https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst#v4100-2025-02-10</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-django/blob/main/docs/changelog.rst">pytest-django's changelog</a>.</em></p> <blockquote> <h2>v4.11.1 (2025-04-03)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Fixed a regression in v4.11.0 for Django <code>TestCase</code> tests using the <code>databases</code> class variable (<code>[#1188](pytest-dev/pytest-django#1188) <https://github.com/pytest-dev/pytest-django/issues/1188></code>__).</li> </ul> <h2>v4.11.0 (2025-04-01)</h2> <p>Compatibility ^^^^^^^^^^^^^</p> <ul> <li>Added official support for Django 5.2 (<code>PR [#1179](pytest-dev/pytest-django#1179) <https://github.com/pytest-dev/pytest-django/pull/1179></code>__).</li> <li>Dropped testing on MySQL’s MyISAM storage engine (<code>PR [#1180](pytest-dev/pytest-django#1180) <https://github.com/pytest-dev/pytest-django/pull/1180></code>__).</li> </ul> <p>Bugfixes ^^^^^^^^</p> <ul> <li> <p>Stopped setting up and serializing databases on test session setup when not needed (the database is not requested / <code>serialized_rollback</code> is not used). On test databases with large amounts of pre-seeded data, this may remove a delay of a few seconds when running <code>pytest --reuse-db</code>.</p> <p>The determination of which databases to setup is done by static inspection of the test suite. Using pytest's dynamic features to request db access, such as :meth:<code>request.getfixturevalue("db") <pytest.FixtureRequest.getfixturevalue></code>, may throw off this analysis. If you start seeing <code>DatabaseOperationForbidden</code> or "unable to open database" errors, this is likely the cause. To fix this, decorate at least one test with the :func:<code>django_db <pytest.mark.django_db></code> marker with appropriate <code>databases</code> and <code>serialized_rollback</code> settings.</p> </li> </ul> <h2>v4.10.0 (2025-02-10)</h2> <p>Compatibility ^^^^^^^^^^^^^</p> <ul> <li>Added official support for Python 3.13.</li> </ul> <p>Improvements ^^^^^^^^^^^^</p> <ul> <li>Added <code>using</code> argument to :fixture:<code>django_assert_num_queries</code> and :fixture:<code>django_assert_max_num_queries</code> to easily specify the database alias to use.</li> </ul> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Fixed lock/unlock of db breaks if pytest is executed twice in the same process.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-django/commit/5ada9c1596ee9e0624801d553995d98d2e3ccce8"><code>5ada9c1</code></a> Release 4.11.1</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/cf3f0bb89be0d741e7c4e10469d0559e86753cc7"><code>cf3f0bb</code></a> fixtures: fixup a regression in previous release for TestCase multi-db support</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/6d5c272519037031f0b68d78dca44727b860d65e"><code>6d5c272</code></a> Release 4.11.0</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/8000db04f07822861331d0df8ef52f9c67eafc00"><code>8000db0</code></a> Only setup and serialize databases as needed by tests</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/6f7fc269f871da0134d9155ca856b29582aa46ce"><code>6f7fc26</code></a> Add optional integration of pytest into django's <code>manage.py test</code></li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/3071a666dce1f60299bf89bd9c268ac7e0ee459d"><code>3071a66</code></a> docs/conf.py: format with ruff format</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/3f44e50ff326c23a44bf5633423d491a251d8eed"><code>3f44e50</code></a> fixtures: avoid unnecessary closure</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/b7328696ad7a5bfc308b60c909972a9166fce8a3"><code>b732869</code></a> Remove testing on MyISAM (<a href="https://redirect.github.com/pytest-dev/pytest-django/issues/1180">#1180</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/e362f4c6303b203e5449ed023b353ad81f40a753"><code>e362f4c</code></a> Add support for Django 5.2 (<a href="https://redirect.github.com/pytest-dev/pytest-django/issues/1179">#1179</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-django/commit/d8dc3d9a62b97c9730111ca7c656dd3b00c479c2"><code>d8dc3d9</code></a> Release 4.10.0</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-django/compare/v4.9.0...v4.11.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
It’s in beta since Feb 19: https://www.djangoproject.com/weblog/2025/feb/19/django-52-beta-1-released/ . Final release expected April 2nd.
Since we're already testing the main branch, few changes are needed.
I copied what to change from #1143.
I’m a bit confused about what entries we include on the testing matrix, so I just added a few that I thought would make sense.