Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated option to pypa/gh-action-pypi-publish action #699

Closed
seifertm opened this issue Dec 3, 2023 · 4 comments · Fixed by #712
Closed

Replace deprecated option to pypa/gh-action-pypi-publish action #699

seifertm opened this issue Dec 3, 2023 · 4 comments · Fixed by #712
Assignees
@ujjwal123123
Labels
enhancement good first issue

Comments

@seifertm
Copy link
Contributor

seifertm commented Dec 3, 2023

The PyPI Upload step in the Deploy job of the CI pipeline emits the following warning:

Warning: Input 'packages_dir' has been deprecated with message: The inputs have been normalized to use kebab-case. Use `packages-dir` instead.

The argument should be adjusted accordingly, in order to get rid of the deprecation warning.
@seifertm seifertm changed the title Replace deprecated option to pypa/gh-action-pypi-publish Replace deprecated option to pypa/gh-action-pypi-publish action Dec 3, 2023
@ujjwal123123
Copy link
Contributor

I would like to work on it. Just to clarify, should I replace packages_dir with packages-dir line 151 of main.yml?

@seifertm
Copy link
Contributor Author

seifertm commented Dec 4, 2023

Based on my current understanding that should be sufficient.
It would be great if you could consult the documentation of the pypa/gh-action-pypi-publish project regarding the deprecation and check if that change is enough.

@ujjwal123123
Copy link
Contributor

Based on the information provided in the README and pypa/gh-action-pypi-publish#125, it seems that modifying packages_dir to packages-dir would suffice. Should I create a pull request for this change?

@seifertm
Copy link
Contributor Author

seifertm commented Dec 6, 2023

@ujjwal123123 Yes, feel free to proceed. Thanks for double-checking!

ujjwal123123 added a commit to ujjwal123123/pytest-asyncio that referenced this issue Dec 7, 2023
@ujjwal123123
[fix] Change packages_dir to packages-dir
87b0e03 
This should fix pytest-dev#699 and prevent the warning
@ujjwal123123 ujjwal123123 mentioned this issue Dec 7, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2023
@ujjwal123123 @seifertm
[fix] Change packages_dir to packages-dir
97b8eb2 
This should fix #699 and prevent the warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ujjwal123123 ujjwal123123

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Change packages_dir to packages-dir ujjwal123123/pytest-asyncio
2 participants
@ujjwal123123 @seifertm