Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHL: Update to PROJ 9.3 #1334

Merged
merged 1 commit into from Sep 9, 2023
Merged

WHL: Update to PROJ 9.3 #1334

merged 1 commit into from Sep 9, 2023

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Aug 30, 2023

  • Closes DEP: PROJ 9.3 #1327
  • Fully documented, including history.rst for all changes and api/*.rst for new API

TODO: vcpkg & PROJ release

@snowman2 snowman2 added this to the 3.6.1 milestone Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1334 (e068fe7) into main (c3e8aca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          20       20           
  Lines        1812     1812           
=======================================
  Hits         1747     1747           
  Misses         65       65           

@dotlambda
Copy link

I get a test failure using PROJ 9.3.0 with pyproj 3.6.0:

=================================== FAILURES ===================================
____________________________ test_repr__conditional ____________________________

    @pytest.mark.grid
    def test_repr__conditional():
        trans_repr = repr(Transformer.from_crs("EPSG:4326+3855", "EPSG:4979"))
        if grids_available("us_nga_egm08_25.tif"):
            assert trans_repr == (
                "<Unknown Transformer: unknown>\n"
                "Description: unavailable until proj_trans is called\n"
                "Area of Use:\n- undefined"
            )
        elif PROJ_GTE_92:
>           assert trans_repr == (
                "<Unknown Transformer: noop>\n"
                "Description: Transformation from EGM2008 height to WGS 84 "
                "(ballpark vertical transformation, without ellipsoid height "
                "to vertical height correction)\n"
                "Area of Use:\n- undefined"
            )
E           AssertionError: assert '<Other Coord... 180.0, 90.0)' == '<Unknown Tra...\n- undefined'
E             - <Unknown Transformer: noop>
E             + <Other Coordinate Operation Transformer: noop>
E               Description: Transformation from EGM2008 height to WGS 84 (ballpark vertical transformation, without ellipsoid height to vertical height correction)
E               Area of Use:
E             - - undefined
E             + - name: World.
E             + - bounds: (-180.0, -90.0, 180.0, 90.0)

test/test_transformer.py:544: AssertionError

@snowman2
Copy link
Member Author

snowman2 commented Sep 8, 2023

See #1315

@snowman2 snowman2 added the dependencies Pull requests that update a dependency file label Sep 9, 2023
@snowman2 snowman2 marked this pull request as ready for review September 9, 2023 01:47
@snowman2 snowman2 merged commit 76b77c8 into pyproj4:main Sep 9, 2023
28 checks passed
@snowman2 snowman2 deleted the proj93 branch September 9, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEP: PROJ 9.3
2 participants