Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add horizontal_datum_name for geographic CRS in CRS.to_cf #1255

Merged
merged 2 commits into from Mar 24, 2023

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 added the bug label Mar 19, 2023
@snowman2 snowman2 added this to the 3.5.0 milestone Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1255 (9405668) into main (8109fc4) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   96.34%   96.40%   +0.06%     
==========================================
  Files          20       20              
  Lines        1805     1810       +5     
==========================================
+ Hits         1739     1745       +6     
+ Misses         66       65       -1     
Impacted Files Coverage Δ
pyproj/crs/_cf1x8.py 98.07% <100.00%> (+0.69%) ⬆️
pyproj/crs/crs.py 98.08% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snowman2 snowman2 merged commit 04ce29a into pyproj4:main Mar 24, 2023
23 checks passed
@snowman2 snowman2 deleted the to_cf_bug branch March 24, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizontal_datum_name missing from the CF version of a CRS, breaking conformity with CF ≥ 1.7
1 participant