Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused code in QuotedString #488

Closed
nijel opened this issue Jun 27, 2023 · 3 comments
Closed

Unused code in QuotedString #488

nijel opened this issue Jun 27, 2023 · 3 comments
Assignees
@ptmcg

Comments

@nijel
Copy link
Contributor

nijel commented Jun 27, 2023

While investigating compatibility issues between Weblate and pyparsing 3.1.0, I've noticed the following code which is no longer used:

pyparsing/pyparsing/core.py

Line 3269 in c8b7664

self.escCharReplacePattern = re.escape(escChar) + "(.)"

The usage of this attribute has been removed in d46eb9e.
@ptmcg
Copy link
Member

ptmcg commented Jun 27, 2023

Very nice, thanks!

@ptmcg ptmcg self-assigned this Jun 30, 2023
ptmcg added a commit that referenced this issue Jun 30, 2023
@ptmcg
Remove unused var in QuotedString (Issue #488)
08f7b39
@ptmcg
Copy link
Member

ptmcg commented Jun 30, 2023

I started looking at this code, and decided to give it a more thorough overhaul, including PEP8-ing the internal variables.

ptmcg added a commit that referenced this issue Jun 30, 2023
@ptmcg
General code cleanup in QuotedString: use "|".join to build inner_pat…
247d332 
…tern instead of string addition with sep character; PEP8 var names; (inspired by Issue #488)
@ptmcg
Copy link
Member

ptmcg commented Jul 30, 2023

Fixed in 3.1.1

@ptmcg ptmcg closed this as completed Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptmcg ptmcg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nijel @ptmcg