Fix windows utf8 encoding issue #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PzaThief
force-pushed
the
fix/windows-utf8
branch
from
7d56d99
to
69bba4a
Compare
gaborbernat
force-pushed
the
fix/windows-utf8
branch
from
69bba4a
to
4dcda32
Compare
gaborbernat
force-pushed
the
fix/windows-utf8
branch
from
2c436fe
to
abb4f71
Compare
PzaThief
force-pushed
the
fix/windows-utf8
branch
from
b673a03
to
8d83667
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
PzaThief
force-pushed
the
fix/windows-utf8
branch
from
8d83667
to
4dfda23
Compare
Sorry for late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch and Powershell do not work properly if non-ASCII text (e.g. "аạąäàáą") is used in the folder name or prompt name.
For Batch case, there is a codepage issue under the problem and cpython's venv has the solution already.
And Powershell assumes Windows 1252 encoding when reading files without BOM. So I added Bom using utf-8-sig encoding.
Batch error screenshot (see broken prompt name after activate)
Powershell error screenshot
