Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printed URLs for Twine uploads should sanitize secrets with regard to alternate repositories that require credentials. #1105

Closed
1 task done
ascheel opened this issue May 9, 2024 · 1 comment

Comments

@ascheel
Copy link

ascheel commented May 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues (open and closed), and could not find an existing issue

What keywords did you use to search existing issues?

password
sanitize
sanitizing
censor
url

Please describe why your using this option

Just creating an issue to match the Pull Request that I've already created. It seemed appropriate. The below PR sanitizes the printed output, clearing any sensitive data from the repository_url so it doesn't get output to screen/logs when using custom repositories.

#1104

Anything else you'd like to mention?

No response

@sigmavirus24
Copy link
Member

This is fixed in 5.1.0 via #1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants