Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix news fragment entries #4891

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

abravalheri
Copy link
Contributor

Summary of changes

Closes

Pull Request Checklist

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Fix weird `../NEWS (links).rst:9: WARNING: Inline literal start-string without end-string.` error in v77.0.0 CI.
- Reorder changlog entries for v77.0.0.
  See rationale in jaraco/skeleton#169
@abravalheri abravalheri marked this pull request as ready for review March 19, 2025 19:22
@abravalheri abravalheri merged commit 7653149 into pypa:main Mar 19, 2025
21 checks passed
abravalheri added a commit that referenced this pull request Mar 19, 2025
@abravalheri abravalheri deleted the fix-docs-v77 branch March 19, 2025 19:30
@webknjaz
Copy link
Member

@abravalheri might be time to migrate to sphinxcontrib-towncrier?

@abravalheri
Copy link
Contributor Author

That looks great, we need to liaise with the skeleton project about that.

I think the practical problem with the warnings for literal start-string without end-string are caused by rst.linker trying to replace a text with the PEP \d+ format that is already inside of a sphinx role.

@webknjaz
Copy link
Member

I know that @jaraco tried it out in a few projects. But there were a couple of limitations in the past that I have addressed in the most recent version.

@jaraco
Copy link
Member

jaraco commented Mar 23, 2025

I have seen sphinxcontrib-towncrier catch some rendering issues early. It's probably worth adopting for that alone, especially since the issues have been addressed. Thanks abravalheri for suggesting to coordinate with skeleton. I'd be interested in exploring adding this to skeleton and see how it performs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants