Reduce Ruff configs that duplicates upstream after skeleton merge #4857
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
approved these changes
Feb 27, 2025
| # Ensure modern type annotation syntax and best practices | ||
|
|
||
| # Ensure modern type annotation syntax and best practices |
There was a problem hiding this comment.
These cleanups of whitespace ideally should be done in skeleton, otherwise there might be some merge conflicts in the future, isn't it?
There was a problem hiding this comment.
Those whitespaces are odd. (btw that was autoformatted). Not sure if I accidentally added them in the skeleton or if Jason accidentally introduced them when merging. I'll take a look, but yeah.
abravalheri
force-pushed
the
Reduce-Ruff-configs-that-duplicates-upstream-after-skeleton-merge
branch
from
9b28b0b to
45375cd
Compare
|
Thank you very much. |
Avasam
deleted the
Reduce-Ruff-configs-that-duplicates-upstream-after-skeleton-merge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
These configs are now repeated with skeleton upstream and can be removed.
Pull Request Checklist
newsfragments/.(See documentation for details)