pkg_resources: Remove unused and shadowed variables
#4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Avasam
force-pushed
the
pkg_resources-remove-unused-and-shadowed
branch
from
745f3c7
to
ba09176
Compare
|
Thanks @Avasam, I think we can merge this one as soon as the CI passes. For future readers wondering if the PR would change the exposed API, we have discussed this in #4242 (comment), and the conclusion is that this PR should be safe ( _initialize_master_working_set is already doing all the work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Extracted from https://github.com/pypa/setuptools/pull/4242/files#r1513644506
Pull Request Checklist
newsfragments/.(See documentation for details)