-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some deprecated code #3948
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
.github/workflows/main.yml
Outdated
@@ -123,7 +123,7 @@ jobs: | |||
- name: Setup Python | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: ${{ matrix.python }}${{ matrix.dev }} | |||
python-version: 3.11-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is maintained upstream in jaraco/skeleton. I'm not sure what it even means to have matrix.python
and matrix.dev
in this section. Probably these lines simply need to be removed upstream. But that still doesn't address the concern that building against the default Python causes problems for Setuptools. Probably this change deserves a comment linking to a bug as to why it's here, because by pinning a version, it creates cruft that someone will have to revisit in the future (maybe just link to the comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jason.
I changed the PR to avoid modifying the workflow.
I believe the error in the CI is a bootstrapping problem, when upgrading the setuptools installation from source. The first time egg_info
runs (via build_meta
) in an environment that comes with an old version setuptools
pre-installed, it will read the previous .dist-info/entry-points.txt
and try to import egg_info.warn_depends_obsolete
, resulting in error.
To avoid this error, the new commit will simply leave a stub behind which can then be removed in future versions.
03366e3
to
333b3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
.github/workflows/main.yml
Outdated
@@ -123,7 +123,7 @@ jobs: | |||
- name: Setup Python | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: ${{ matrix.python }}${{ matrix.dev }} | |||
python-version: 3.11-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is maintained upstream in jaraco/skeleton. I'm not sure what it even means to have matrix.python
and matrix.dev
in this section. Probably these lines simply need to be removed upstream. But that still doesn't address the concern that building against the default Python causes problems for Setuptools. Probably this change deserves a comment linking to a bug as to why it's here, because by pinning a version, it creates cruft that someone will have to revisit in the future (maybe just link to the comment).
This is done so in the future we are reminded to remove the deprecated code.
…pdating from source
333b3c0
to
6ef81fe
Compare
setuptools removed a long deprecated function (which was only used on Windows there) so add a minimal variant back. See pypa/setuptools#3948 for the removal
Summary of changes
Remove code that has been deprecated for a while:
depends.txt
(warning introduced in 2005)egg_info
directories, probably created by previous versions of setuptools (warning introduced in 2005)easy_install
(easy_install
itself has been deprecated for a while).egg_info.get_pkg_info_revision
, deprecated since 2015pyproject.toml
: whenpyproject.toml
was introduced there were some people writing invalid files, ref (Projects that containpyproject.toml
not compliant with standards are failing on v61. #3199 and [Docs] Example may accidentally be encouraging users to write invalidpyproject.toml
files cibuildwheel#1064). As a grace period was introduced for users to fix this up.dist._get_unpatched
, deprecated since 2016.Closes
Pull Request Checklist
changelog.d/
.(See documentation for details)