Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop advertising adding wheel as an unconditional PEP 517 build dependency #203

Closed
webknjaz opened this issue Jan 9, 2024 · 6 comments
Closed

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 9, 2024

It's already pulled in by setuptools automatically, when building wheels is requested from the frontend. If only sdists are being build, pyproject.toml shouldn't forcefully inject this dependency into the ephemeral build env.

This has mostly been cleaned up from other places in the ecosystem and should be done here as well.

Related PRs:

Action items:

  • Find all the pyproject.toml files that have setuptools in their [build-system].requires
  • Delete wheel from the lists where it's also present
@pfmoore
Copy link
Member

pfmoore commented Jan 9, 2024

Find all the pyproject.toml files that have setuptools in their [build-system].requires

That sounds more complex than I think you mean - isn't it just the following one line?

https://github.com/pypa/sampleproject/blob/main/pyproject.toml#L153

@webknjaz
Copy link
Member Author

webknjaz commented Jan 9, 2024

You're right. I think there was some other repo under @pypa that has multiple project examples in it that I confused this one with.

@webknjaz
Copy link
Member Author

webknjaz commented Jan 9, 2024

I was thinking of https://github.com/pypa/sample-namespace-packages, it seems.

@chrysle
Copy link
Contributor

chrysle commented Feb 3, 2024

#204 addresses this.

@webknjaz
Copy link
Member Author

webknjaz commented Feb 3, 2024

@chrysle as I said above — I originally thought of a different repo. Also, that PR does too much stuff than just removing 9 bytes from a single place, which would've been much cleaner.

@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

I guess this can be closed, nevertheless? What's done is done.

@webknjaz webknjaz closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants