Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-all is slow #1353

Open
flying-sheep opened this issue Apr 17, 2024 · 3 comments
Open

upgrade-all is slow #1353

flying-sheep opened this issue Apr 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Apr 17, 2024

How would this feature be useful?

When running topgrade, pipx is the slowest step when there are no upgrades

Describe the solution you'd like

pipx upgrade-all should check if upgrades are available in parallel. It’s fine if they’re upgraded in sequence, but taking 2 seconds to check if 3 tools have upgrades pending is a bit slow.

Maybe using a connection pool with limited size if we want to overengineer things. I assume for most users, starting x requests, where x is the number of installed tools would be fine.

Describe alternatives you've considered

none

@chrysle chrysle added the enhancement New feature or request label Apr 17, 2024
@chrysle
Copy link
Contributor

chrysle commented Apr 19, 2024

pipx upgrade-all should check if upgrades are available in parallel. It’s fine if they’re upgraded in parallel, but taking 2 seconds to check if 3 tools have upgrades pending is a bit slow.

Agreed. I'll look into this.

@flying-sheep
Copy link
Contributor Author

Great! Small correction, I meant

It’s fine if they’re upgraded in parallelsequence

@chrysle
Copy link
Contributor

chrysle commented Apr 21, 2024

I think this would best be tackled after #149 has been addressed, as then we'll be able to handle requests to the simple API for newer versions in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants