Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted local editable file file fixes #5886

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Assorted local editable file file fixes #5886

merged 7 commits into from
Aug 29, 2023

Conversation

matteius
Copy link
Member

The issue

In the refactor away from requirementslib, I incorrectly made an assumption that if the install line is found as a relative file path that its intended as an local file install, but this broke for cases where the file or directory name matched the named package to be pulled from a package index.

The fix

Editable installs will need to be specified by passing the editable: true or -e arg, and not inferred.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Sorry, something went wrong.

@matteius matteius marked this pull request as ready for review August 28, 2023 23:27
@matteius matteius changed the title Do not consider something a local editable file unless the -e flag is passed. Do not consider local editable file unless the -e flag is passed. Aug 29, 2023
@matteius matteius changed the title Do not consider local editable file unless the -e flag is passed. Do not consider local editable file unless the -e flag is passed Aug 29, 2023
@matteius matteius changed the title Do not consider local editable file unless the -e flag is passed Assorted local editable file file fixes Aug 29, 2023
@matteius matteius merged commit 8aa204e into main Aug 29, 2023
@matteius matteius deleted the issue-5885 branch August 29, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant