Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test macos-x86_64 and arm64 in different venv dir #1750

Merged
merged 2 commits into from Feb 3, 2024

Conversation

njzjz
Copy link
Contributor

@njzjz njzjz commented Feb 1, 2024

pip cannot install wheels with different architecture into the same venv directory. (See #1746 (comment))

Downstream test:
Before this PR: failed log
After this PR: pass log

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that is an unfortunate bug! Thank you for the fix! A regression test would be great if you have time to create it.

@njzjz njzjz changed the title test macos_x86-64 and arm64 in different venv dir test macos-x86_64 and arm64 in different venv dir Feb 2, 2024
@joerick
Copy link
Contributor

joerick commented Feb 2, 2024

I'll look at adding a unit integration test now...

@joerick joerick merged commit 88c1134 into pypa:main Feb 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants