feat: add schema and validate-pyproject support #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerick
reviewed
Sep 21, 2023
henryiii
force-pushed
the
henryiii/feat/schema
branch
from
0297018
to
a5db7f8
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/schema
branch
from
a5db7f8
to
62ec642
Compare
|
Also added a mechanism to test all the docs examples. Several fixes of the schema came from that. :) |
henryiii
commented
Sep 21, 2023
henryiii
commented
Sep 21, 2023
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
joerick
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a json schema. This supports validate-pyproject, allowing it to check a
tool.cibuildwheelsection. I wrote a Python 3.10+bin/generate_schema.pyto make the schema as I didn't see a good way to do the OS sections and overrides by hand. I mostly tried to replicate the current behavior, though we technically could be more strict with a schema than in reality, since it's optional to validate it.Testing by validating the defaults toml, a few manual examples, and running all the docs examples though.
Once we have this, we could also contribute it to SchemaStore, which would make it work in vscode, etc.