Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIBW_CONTAINER_ENGINE splits on : when it shouldn't #1600

Closed
makslevental opened this issue Sep 6, 2023 · 3 comments · Fixed by #1621
Closed

CIBW_CONTAINER_ENGINE splits on : when it shouldn't #1600

makslevental opened this issue Sep 6, 2023 · 3 comments · Fixed by #1621

Comments

@makslevental
Copy link

makslevental commented Sep 6, 2023

Description

CIBW_CONTAINER_ENGINE="docker; create_args: -p=8080:8080"

gets parsed into

  container_engine: 
    name: docker
    create_args: ['-p=8080', ':', '8080']

problem is here

shlexer = shlex.shlex(key_value_string, posix=True, punctuation_chars=";:")

potential fix from here:

shlexer = shlex.shlex(key_value_string, posix=True, punctuation_chars=True)
shlexer.wordchars += ':'

with this change, CIBW_CONTAINER_ENGINE="docker; create_args : -p=8080:8080" (note the space after create_args) parses to fields=[['docker'], ['create_args', ':', '-p=8080:8080']].

@joerick
Copy link
Contributor

joerick commented Sep 19, 2023

Ah, that's unfortunate. A workaround would be to quote the create_args, e.g. CIBW_CONTAINER_ENGINE="docker; create_args: '-p=8080:8080'". However, I'll work on a fix too.

@joerick
Copy link
Contributor

joerick commented Sep 19, 2023

Fix for this in #1621

@makslevental
Copy link
Author

@joerick - I had tried quoting various ways but couldn't get it to work. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants