Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Python 3.7 support #1479

Merged
merged 4 commits into from Apr 19, 2023
Merged

fix: Python 3.7 support #1479

merged 4 commits into from Apr 19, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Apr 19, 2023

This restores Python 3.7 support, and adds testing for it, and adds static checking to keep this bug from popping up again. I already had _compat.* work started, and ran into a bug in Ruff that kept .typing from being used, so I went ahead and used that to work around the Ruff bug. I'm using a _compat.<stdlib> form for most of my other projects, and am happy with it.

  • ci: add Python 3.7
  • fix: restore Python 3.7 support

Fixes #1478. See also astral-sh/ruff#4013.

TODO:

  • I need to restore non-backported typing to cibuildwheel.typing.
  • Add tomllib to _compat

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review April 19, 2023 03:48
@mayeut
Copy link
Member

mayeut commented Apr 19, 2023

Python 3.7 support issue should have been caught by Travis CI. It exits with a successful status even when there are errors.

@joerick
Copy link
Contributor

joerick commented Apr 19, 2023

I'll merge this as I'd like to get a bug fix release out, the _compat thing looks good to me. I agree with @mayeut though, we should have had CI coverage for 3.7 on Travis, so we should figure out what happened there.

@joerick joerick merged commit 52572cc into pypa:main Apr 19, 2023
25 checks passed
@joerick
Copy link
Contributor

joerick commented Apr 19, 2023

Thanks for fixing so quickly @henryiii. I've released a new version with the fix. Created #1480 for the CI check, I don't think we'll need this extra Github Actions check long-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cibuildwheel 2.12.2 broke support for Python 3.7
3 participants