Fix _PyFrameEvalFunction receives an _PyInterpreterFrame since Python 3.11
#3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecarrara
changed the title
_PyFrameEvalFunction receives an _PyInterpreterFrame since Python 3.11_PyFrameEvalFunction receives an _PyInterpreterFrame since Python 3.11
davidhewitt
reviewed
Oct 8, 2023
pyo3-ffi/src/cpython/ceval.rs
Outdated
Comment on lines
5
to
6
| #[cfg(any(PyPy, Py_3_11))] | ||
| opaque_struct!(_PyInterpreterFrame); |
There was a problem hiding this comment.
It looks like (at least on CPython main) that this symbol resides in cpython/pyframe.h. Can you please create the corresponding .rs file and place this there?
mejrs
reviewed
Oct 9, 2023
pyo3-ffi/src/cpython/pyframe.rs
Outdated
| @@ -0,0 +1,2 @@ | |||
| #[cfg(any(PyPy, Py_3_11))] | |||
There was a problem hiding this comment.
Is this available in PyPy? I couldn't find anything about it.
There was a problem hiding this comment.
I couldn't find it either 😅
I've added #[cfg(not(PyPy))] to the pub(crate) mod pyframe; line on src/cpython/mod.rs because PyPy does not have something like "pyframe.h" in their source code.
Commit: 4931b00
mejrs
reviewed
Oct 9, 2023
mejrs
approved these changes
Oct 10, 2023
ecarrara
force-pushed
the
fix-eval-frame-py311
branch
from
27da8ff
to
0e0e662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.11 the
_PyFrameEvalFunctionreceives a_PyInterpreterFrameopaque struct.Python 3.11.0 (alpha 7) changelog:
https://docs.python.org/3/whatsnew/changelog.html#id143