Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark showing that extract::<i64> is costly due to PyNumber_Index trying hard. #3183

Merged
merged 1 commit into from May 26, 2023

Conversation

adamreichold
Copy link
Member

The benchmarks from #3182 to keep around for later and to play around with.

@adamreichold adamreichold added the CI-skip-changelog Skip checking changelog entry label May 25, 2023
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks.

bors r+

bors bot added a commit that referenced this pull request May 26, 2023
3183: Add benchmark showing that extract::<i64> is costly due to PyNumber_Index trying hard. r=davidhewitt a=adamreichold

The benchmarks from #3182 to keep around for later and to play around with.

Co-authored-by: Adam Reichold <adam.reichold@t-online.de>
@bors
Copy link
Contributor

bors bot commented May 26, 2023

Build failed:

@adamreichold
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented May 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit cd4b27f into main May 26, 2023
33 checks passed
@bors bors bot deleted the bench-extract branch May 26, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants