ModbusSlaveContext, remove zero_mode parameter. #2354
Merged
+5
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
added a commit
that referenced
this pull request
Oct 4, 2024
janiversen
added a commit
that referenced
this pull request
Oct 6, 2024
janiversen
added a commit
that referenced
this pull request
Oct 9, 2024
janiversen
added a commit
that referenced
this pull request
Oct 9, 2024
janiversen
added a commit
that referenced
this pull request
Oct 13, 2024
janiversen
added a commit
that referenced
this pull request
Oct 21, 2024
janiversen
added a commit
that referenced
this pull request
Oct 22, 2024
janiversen
added a commit
that referenced
this pull request
Oct 23, 2024
janiversen
added a commit
that referenced
this pull request
Oct 26, 2024
|
Sigh what's the rationale for this change? My codebase contains a data store which pretty much depends on accesses to it being zero-based, and now I need to refactor that rather intrusively … |
|
I do not think there needs to be a rationale to be discussed publicly ! Why do you need to "refactor that rather intrusively", you make a new class that inherits from ModbusSlaveContext, and does whatever you need done. Anyhow ModbusSlaveContext is really very old with a number of nasty problems, so it is in the process of being replaced by a datastore that is more flexible and powerful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.