Update BinaryPayloadDecoder._unpack_words documentation #2310
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no parameter fstring for this function
janiversen
approved these changes
Sep 9, 2024
| @@ -330,7 +330,7 @@ def _unpack_words(self, handle) -> bytes: | |||
| # Change Word order if little endian word order # | |||
| # Pack values back based on correct byte order # | |||
| # ---------------------------------------------- # | |||
| :param fstring: | |||
|
|
|||
There was a problem hiding this comment.
Good catch, except this is an internal function, where we tend not to document the parameters.
janiversen
added a commit
that referenced
this pull request
Sep 9, 2024
|
Solve in #2312, since you have not allowed maintainers to update your PR. I have kept you as author. Thanks for the PR. |
|
Sorry, I did not check the options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no parameter "fstring" for this function