simulator: Fix context single parameter #2264
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an incomplete feature in
Commit: d32947517087214d28d71cdcbf3c02355526ab68 Feature/simulator addressing
.The
single
parameter was used incorrectly when ModbusServerContext was initialized. This caused the simulator to not work correctly when the configuration "device_id" was used. The context would wrap the dict in another, having completely incorrect, resulting in using an invalid object.Fix it by defining single correctly.
The ModbusServerContext initialization looks like this:
So if single == True AND
device_id
is defined with an address, this will eventuall result inself._slaves
being initialized asinstead of
Testing