Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded attribute from version #1383

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Remove unneeded attribute from version #1383

merged 1 commit into from
Feb 21, 2023

Conversation

alexrudd2
Copy link
Collaborator

Fixes pymodbus/version.py:41: error: "Version" has no attribute "__name__" [attr-defined]

the comment refers to "epydoc", which has not been used for a long time. I could find no other use.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexrudd2 alexrudd2 requested a review from janiversen February 21, 2023 20:34
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@janiversen janiversen merged commit ef72a96 into dev Feb 21, 2023
@janiversen janiversen deleted the version-mypy branch February 21, 2023 21:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants