Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid-name regression for class attributes in subclasses #9772

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Fixes #9765

Verified

This commit was signed with the committer’s verified signature.
joyeecheung Joyee Cheung
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: invalid-name backport maintenance/3.3.x labels Jul 7, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.2.6 milestone Jul 7, 2024
@jacobtylerwalls jacobtylerwalls requested a review from mbyrnepr2 July 7, 2024 17:07
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (52955ba) to head (872b60c).
Report is 143 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9772   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         174      174           
  Lines       18878    18878           
=======================================
  Hits        18094    18094           
  Misses        784      784           
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.63% <100.00%> (ø)

Copy link
Contributor

github-actions bot commented Jul 7, 2024

🤖 Effect of this PR on checked open source code: 🤖

Effect on music21:
The following messages are no longer emitted:

  1. invalid-name:
    Class attribute name "registerOutputSubformatExtensions" doesn't conform to '([A-Za-z_][A-Za-z0-9_]{2,30}|(__.__))$' pattern*
    https://github.com/cuthbertLab/music21/blob/204e9d0b9eec2f2d6ff8d8d3b13c41f912050604/music21/converter/subConverters.py#L355
  2. invalid-name:
    Class attribute name "registerOutputSubformatExtensions" doesn't conform to '([A-Za-z_][A-Za-z0-9_]{2,30}|(__.__))$' pattern*
    https://github.com/cuthbertLab/music21/blob/204e9d0b9eec2f2d6ff8d8d3b13c41f912050604/music21/converter/subConverters.py#L411
  3. invalid-name:
    Class attribute name "registerOutputSubformatExtensions" doesn't conform to '([A-Za-z_][A-Za-z0-9_]{2,30}|(__.__))$' pattern*
    https://github.com/cuthbertLab/music21/blob/204e9d0b9eec2f2d6ff8d8d3b13c41f912050604/music21/converter/subConverters.py#L834

This comment was generated for commit 872b60c

@jacobtylerwalls jacobtylerwalls merged commit b9a42e8 into main Jul 7, 2024
50 checks passed
@jacobtylerwalls jacobtylerwalls deleted the tear-down-invalid-name branch July 7, 2024 19:42
github-actions bot pushed a commit that referenced this pull request Jul 7, 2024

Verified

This commit was signed with the committer’s verified signature.
joyeecheung Joyee Cheung
(cherry picked from commit b9a42e8)
jacobtylerwalls added a commit that referenced this pull request Jul 7, 2024
…) (#9775)

(cherry picked from commit b9a42e8)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x C: invalid-name False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid-name false positive on assignment to class attribute tearDown
2 participants