-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add --prefer-stubs=y
option
#9632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we "hide" the astroid upgrades and create a fragment for each new things it brings (i.e. not in internal, like I did for 3.2.0) or announce them in internal (with functional changes too like you did here) ? Both work imo, and creating fragments for each new feature from astroid is more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to upgrade the doc/example locally.
This comment has been minimized.
This comment has been minimized.
Ouch, re: windows failures. Here comes astroid 3.2.2....
|
Urg, it's a time when the heaviness of doing a release is actually felt. |
This comment has been minimized.
This comment has been minimized.
This reverts commit 341ed71.
Luckily, it was just an issue with a nondeterminstic sort, fixed with a better test assertion. |
Type of Changes
Description
Put the "prefer stubs" feature from pylint-dev/astroid#2375 under a feature flag.
Depends on pylint-dev/astroid#2437.