[Backport maintenance/3.0.x] Fix false positive for unnecessary-lambda with kwargs in the call but not the lambda
#9200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This simplifies the check for the call having kwargs but not the lambda. (cherry picked from commit 2289c71)
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
Oct 29, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.0.x #9200 +/- ##
=====================================================
+ Coverage 95.76% 95.78% +0.01%
=====================================================
Files 173 173
Lines 18691 18686 -5
=====================================================
- Hits 17900 17898 -2
+ Misses 791 788 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2289c71 from #9149.