Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/2.17.x] Fix Pyreverse optional annotation bug #9019

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2023

Backport a21f5d3 from #9016.

* Add alternative optional bug test cases

* Fix Pyreverse optional annotation bug

* Fix type error

(cherry picked from commit a21f5d3)
@Pierre-Sassoulas Pierre-Sassoulas added Bug 🪲 pyreverse Related to pyreverse component labels Sep 9, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.6 milestone Sep 9, 2023
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) September 9, 2023 18:17
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #9019 (1a75cdc) into maintenance/2.17.x (094a774) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #9019   +/-   ##
===================================================
  Coverage               95.57%   95.57%           
===================================================
  Files                     178      178           
  Lines                   18865    18865           
===================================================
  Hits                    18030    18030           
  Misses                    835      835           
Files Changed Coverage Δ
pylint/pyreverse/utils.py 94.28% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 259fbd2 into maintenance/2.17.x Sep 9, 2023
27 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9016-to-maintenance/2.17.x branch September 9, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 pyreverse Related to pyreverse component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants