Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exempt parents with only annotations from invalid-enum-extension #8834

Merged
merged 1 commit into from Jul 8, 2023
Merged

Exempt parents with only annotations from invalid-enum-extension #8834

merged 1 commit into from Jul 8, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #8830

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.2.x labels Jul 7, 2023
@jacobtylerwalls jacobtylerwalls added this to the 2.17.5 milestone Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #8834 (5f4245d) into main (f815e9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8834   +/-   ##
=======================================
  Coverage   95.89%   95.90%           
=======================================
  Files         173      173           
  Lines       18511    18515    +4     
=======================================
+ Hits        17752    17756    +4     
  Misses        759      759
Impacted Files Coverage Ξ”
pylint/checkers/classes/class_checker.py 93.38% <100.00%> (+0.02%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on home-assistant:
The following messages are no longer emitted:

  1. too-many-instance-attributes:
    Too many instance attributes (8/7)
    https://github.com/home-assistant/core/blob/c26dc0940ce03cd66406543b18350a649fe0f4e5/homeassistant/components/zone/__init__.py#L315

Effect on pytest:
The following messages are now emitted:

  1. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/skipping.py#L84
  2. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/skipping.py#L203
  3. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/skipping.py#L291
  4. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/debugging.py#L33
  5. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/debugging.py#L101
  6. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/debugging.py#L104
  7. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/junitxml.py#L96
  8. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/junitxml.py#L487
  9. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/junitxml.py#L490
  10. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/fixtures.py#L96
  11. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/fixtures.py#L364
  12. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/fixtures.py#L1141
  13. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/fixtures.py#L1186
  14. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/fixtures.py#L1497
  15. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/pytester.py#L280
  16. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/python_api.py#L804
  17. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/python_api.py#L926
  18. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/python_api.py#L964
  19. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/python_api.py#L990
  20. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L133
  21. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L298
  22. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L327
  23. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1242
  24. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1274
  25. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1274
  26. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1293
  27. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1293
  28. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1390
  29. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1391
  30. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1408
  31. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1412
  32. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/terminal.py#L1427
  33. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/doctest.py#L162
  34. deprecated-typing-alias:
    'typing.Callable' is deprecated, use 'collections.abc.Callable' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L414

The following messages are no longer emitted:

  1. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/unittest.py#L39
  2. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/unittest.py#L40
  3. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/reports.py#L97
  4. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/main.py#L633
  5. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/main.py#L686
  6. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/main.py#L690
  7. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/main.py#L763
  8. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L518
  9. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L691
  10. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L695
  11. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L754
  12. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/nodes.py#L768
  13. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/python.py#L348
  14. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/monkeypatch.py#L99
  15. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/monkeypatch.py#L132
  16. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/monkeypatch.py#L133
  17. deprecated-typing-alias:
    'typing.Callable' is deprecated, use 'collections.abc.Callable' instead
    https://github.com/pytest-dev/pytest/blob/6995257cf470d2143ad1683824962de4071c0eb7/src/_pytest/_py/error.py#L80

Effect on coverage:
The following messages are now emitted:

  1. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/sqlitedb.py#L160

The following messages are no longer emitted:

  1. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/inorout.py#L124
  2. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/inorout.py#L525
  3. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/inorout.py#L540
  4. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/misc.py#L83
  5. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/execfile.py#L42
  6. deprecated-typing-alias:
    'typing.Tuple' is deprecated, use 'tuple' instead
    https://github.com/nedbat/coveragepy/blob/7a32450257db47e10ac4f28451509a9a1577d564/coverage/html.py#L80

This comment was generated for commit 5f4245d

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@Pierre-Sassoulas Pierre-Sassoulas merged commit 538a8fe into pylint-dev:main Jul 8, 2023
44 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 8, 2023
@jacobtylerwalls @github-actions
Exempt parents with only annotations from invalid-enum-extension (#…
dc59503 
…8834)

(cherry picked from commit 538a8fe)
@github-actions github-actions bot mentioned this pull request Jul 8, 2023
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Jul 8, 2023
@github-actions @jacobtylerwalls
Exempt parents with only annotations from invalid-enum-extension (#…
d690dd8 
…8834) (#8835)

(cherry picked from commit 538a8fe)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the enum-type-annotation branch July 8, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.17.5
Development

Successfully merging this pull request may close these issues.

False positive invalid-enum-extension for Enum parent class with annotations
2 participants
@jacobtylerwalls @Pierre-Sassoulas