Fix a crash when calling copy.copy() without args
#8784
Merged
+31
β5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Crash π₯
jacobtylerwalls
commented
Jun 18, 2023
Comment on lines
+35
to
+37
| copy.copy(**{"x": os.environ}) # [shallow-copy-environ] | ||
| copy.copy(**{"y": os.environ}) # [unexpected-keyword-arg] | ||
| copy.copy(y=os.environ) # [no-value-for-parameter, unexpected-keyword-arg] |
There was a problem hiding this comment.
I would expect the last two lines to raise the same set of messages. We don't use inference to analyze whether **kwargs contains the missing named parameter x. We could.
There was a problem hiding this comment.
Captured in #8785
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8784 +/- ##
=======================================
Coverage 95.83% 95.84%
=======================================
Files 173 173
Lines 18459 18466 +7
=======================================
+ Hits 17691 17698 +7
Misses 768 768
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2023
(cherry picked from commit 92485a3)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 18, 2023
(cherry picked from commit 92485a3) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8774