Better regex for private attribute check #8081
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
approved these changes
Jan 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8081 +/- ##
==========================================
+ Coverage 95.43% 95.44% +0.01%
==========================================
Files 176 176
Lines 18545 18545
==========================================
+ Hits 17698 17700 +2
+ Misses 847 845 -2
|
Pierre-Sassoulas
approved these changes
Jan 19, 2023
|
Thank you Marc ! I don't want to release another 2.15 version, let's put this in 2.16.0 directly, we're going to release soon anyway. |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fea2af9 |
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent regex timeout issues for methods with unreasonable many leading underscores (> 80T).