Mention class lacking implementation in abstract-method message

[harupy]

Bug description

from abc import abstractmethod, ABCMeta


class WildAnimal(metaclass=ABCMeta):
    @abstractmethod
    def make_sound(self):
        pass


class Panther(WildAnimal):
    def make_sound(self):
        raise NotImplementedError("Panther")


class PantherChild(Panther):
    pass

pylint raise the following error against the code above?

a.py:15:0: W0223: Method 'make_sound' is abstract in class 'Panther' but is not overridden (abstract-method)

Is this a false positive?

Configuration

No response

Command used

# Save the code above as a.py and then run:
docker run --rm -w /app -v $(pwd)/a.py:/app/a.py python:3.7 bash -c "pip install pylint && pylint --disable=C,R a.py"

Pylint output

************* Module a
a.py:15:0: W0223: Method 'make_sound' is abstract in class 'Panther' but is not overridden (abstract-method)

Expected behavior

pylint should not raise abstract-method because make_sound is overridden in Panther?

Pylint version

3.7.13

OS / Environment

No response

Additional dependencies

No response

[jacobtylerwalls]

It's not overridden in PantherChild, because it's reported on line 15. We could add the child class in the message output, though.

[harupy]

@jacobtylerwalls Thanks for the comment! Is Panther.make_sound considered an abstract method since it contains raise NotImplementedError("Panther")?

[jacobtylerwalls]

Exactly!

https://pylint.pycqa.org/en/latest/user_guide/messages/warning/abstract-method.html

[clavedeluna]

Happy to pick this up but just to verify, is the ask to change this output

Method 'make_sound' is abstract in class 'Panther' but is not overridden (abstract-method)

to this?

Method 'make_sound' is abstract in class 'Panther' but is not overridden in child class PantherChild (abstract-method)

?

[DanielNoord]

Yes! That makes the error a little bit more actionable!