Fix testing + coverage #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 87.82% 91.24% +3.41%
==========================================
Files 34 18 -16
Lines 419 514 +95
Branches 85 97 +12
==========================================
+ Hits 368 469 +101
+ Misses 48 33 -15
- Partials 3 12 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stdedos
force-pushed
the
ci/fix-test-coverage
branch
3 times, most recently
from
8406b11
to
c4a9409
Compare
|
@Pierre-Sassoulas not a strong necessity, but rlespinasse/github-slug-action@v4 would help |
Merged
stdedos
force-pushed
the
ci/fix-test-coverage
branch
2 times, most recently
from
9f096e2
to
fe28788
Compare
* Drop `py312` to combat pylint-dev#16 * Install `--editable`, so that Python uses the correct source files for coverage * Ignore `tests/input/**/*.py` from coverage - they are not ran properly * Again improve on artifact naming Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos
force-pushed
the
ci/fix-test-coverage
branch
from
fe28788
to
c208abb
Compare
Pierre-Sassoulas
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py312to combat Why does tox in Github Actions on Pull Request pull ALL the Pythons (**INCLUDING** 3.12)? #16--editable, so that Python uses the correct source files for coveragetests/input/**/*.pyfrom coverage - they are not ran properlySigned-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com