Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.3rc0 #17

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

stdedos
Copy link
Collaborator

@stdedos stdedos commented Oct 18, 2023

Additionally, fixes #13

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

@stdedos stdedos added this to the Release v1.1.x milestone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f8da197) 91.24% compared to head (4298cc7) 91.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          18       18           
  Lines         514      514           
  Branches       97       97           
=======================================
  Hits          469      469           
  Misses         33       33           
  Partials       12       12           
Flag Coverage Δ
3.10 91.05% <ø> (ø)
3.11 91.05% <ø> (ø)
3.6 91.05% <ø> (ø)
3.7 91.05% <ø> (ø)
3.8 91.05% <ø> (ø)
3.9 91.05% <ø> (ø)
macos-latest 91.05% <ø> (ø)
ubuntu-20.04 91.05% <ø> (ø)
ubuntu-latest 91.05% <ø> (ø)
windows-latest 91.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdedos
Copy link
Collaborator Author

stdedos commented Oct 18, 2023

Tests were verified manually to be passing (i.e., all show OK except py312)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stdedos stdedos mentioned this pull request Oct 18, 2023
@stdedos stdedos force-pushed the release/v1.1.3 branch 2 times, most recently from c5b2678 to 9c92202 Compare October 19, 2023 07:05
@stdedos stdedos self-assigned this Oct 19, 2023
@stdedos
Copy link
Collaborator Author

stdedos commented Oct 19, 2023

So ... how does it feel @Pierre-Sassoulas to release Friday at 11am? 😅

Additionally, fixes pylint-dev#13

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos stdedos changed the title Release v1.1.3 Release v1.1.3rc0 Oct 19, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any issues releasing on a Friday, especially when the current release is broken 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4971561 into pylint-dev:master Oct 19, 2023
23 checks passed
@stdedos
Copy link
Collaborator Author

stdedos commented Oct 19, 2023

I don't have any issues releasing on a Friday, especially when the current release is broken 😄

Well, define broken 😅

There are bugs. How serious/critical they are? Idk

@Pierre-Sassoulas
Copy link
Member

I mean broken with pylint 3.0, a 1.1.3 release would prevent new install of pylint-pytest to upgrade to a pylint version it's not compatible with.

@Pierre-Sassoulas
Copy link
Member

But yeah, it's possible to just add a pylint<3 in requirements for users.

stdedos added a commit to stdedos/pylint-pytest that referenced this pull request Oct 23, 2023
…ter-unused-argument

# By Stavros Ntentos (15) and others
# Via GitHub (9) and Stavros Ntentos (1)
* origin/master:
  Release v1.1.3
  Fixing _is_pytest_fixture
  test direct import
  Improve packaging + Release v1.1.3rc1
  Release v1.1.3rc0 (pylint-dev#17)
  Fix testing + coverage
  Improvements for `.github/workflows/run-tests.yaml`
  Fix the repository badges
  Roll back `from __future__ import annotations` for Python 3.6
  Fix mypy issues
  Activate mypy in pre-commit
  [mypy] Fix Item "None" of "Optional[Module]" has no attribute "__file__"
  Carry over some `.pylintrc` configuration
  Minor re-ordering of the `tool.pylint`, with some comments
  Move the pylint configuration to pyproject.toml
  [pylint] Add pylint in the continuous integration and pre-commit
  Activate ruff, ignore the typing of classvar
  Upgrade the changelog for 1.1.3a0 release (pylint-dev#10)
  Use ruff instead of flake8 pyupgrade autoflake and isort
  Enable https://github.com/asottile/pyupgrade + `.git-blame-ignore-revs`
  `pre-commit run -a`
  Add `.pre-commit-config.yaml`
  Add a release job to publish on pypi on github tag creation
  MOAR Improvements: Cross-OS testing, `.gitignore` updates, supporting only `pylint<3`, coverage at Codecov, drop other CI
  CI: Modernize, MOAR Pythons, GH-Actions

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

# Conflicts:
#	pylint_pytest/checkers/fixture.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Fix Project URLs
2 participants