Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pylint in pre-commit config #2440

Merged
merged 3 commits into from
May 16, 2024
Merged

Upgrade pylint in pre-commit config #2440

merged 3 commits into from
May 16, 2024

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining astroid or the dev workflow label May 16, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.3.0 milestone May 16, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas
Copy link
Member

Look like the suppression is not useless in the CI

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented May 16, 2024

Where do we bump the astroid pylint version in the pre-commit config?

@jacobtylerwalls jacobtylerwalls changed the title Fix pylint 3.2 diagnostics Upgrade pylint in pre-commit config May 16, 2024
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) May 16, 2024 12:03
@Pierre-Sassoulas Pierre-Sassoulas disabled auto-merge May 16, 2024 12:06
@Pierre-Sassoulas
Copy link
Member

Waiting on #2441 being merged to squash this.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.79%. Comparing base (ee06feb) to head (188e843).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
- Coverage   92.79%   92.79%   -0.01%     
==========================================
  Files          94       94              
  Lines       11109    11110       +1     
==========================================
  Hits        10309    10309              
- Misses        800      801       +1     
Flag Coverage Δ
linux 92.59% <50.00%> (-0.01%) ⬇️
pypy 92.79% <50.00%> (-0.01%) ⬇️
windows 92.69% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/nodes/scoped_nodes/scoped_nodes.py 92.52% <ø> (ø)
astroid/nodes/node_classes.py 94.68% <50.00%> (-0.05%) ⬇️

@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) May 16, 2024 12:13
@jacobtylerwalls jacobtylerwalls disabled auto-merge May 16, 2024 12:13
@jacobtylerwalls jacobtylerwalls merged commit 16da308 into main May 16, 2024
19 of 20 checks passed
@jacobtylerwalls jacobtylerwalls deleted the fix-pylint-msgs branch May 16, 2024 12:14
jacobtylerwalls added a commit that referenced this pull request Jul 9, 2024
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
jacobtylerwalls added a commit that referenced this pull request Jul 9, 2024
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants