Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.7 #430

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Drop support for EOL Python 3.7 #430

merged 4 commits into from
Jun 6, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 3, 2023

Changes proposed in this pull request:

  • Drop support for Python 3.7, EOL this month
  • Not planning a major bump, because requires-python = ">=3.8" will make sure people get the right version
  • Fix a test that checking for .gif, the data is now .png
  • Some test refactoring, including replace helper methods that were useful with unittest and less so with pytest

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #430 (47eda3e) into main (8d8263c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   90.07%   90.02%   -0.06%     
==========================================
  Files          12       12              
  Lines        2186     2185       -1     
==========================================
- Hits         1969     1967       -2     
- Misses        217      218       +1     
Flag Coverage Δ
ubuntu-latest 90.02% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylast/__init__.py 89.70% <100.00%> (-0.11%) ⬇️
tests/test_album.py 100.00% <100.00%> (ø)
tests/test_library.py 100.00% <100.00%> (ø)
tests/test_librefm.py 100.00% <100.00%> (ø)
tests/test_network.py 89.63% <100.00%> (ø)
tests/test_pylast.py 100.00% <100.00%> (ø)
tests/test_user.py 100.00% <100.00%> (ø)

@hugovk hugovk merged commit 5f302e0 into main Jun 6, 2023
24 of 25 checks passed
@hugovk hugovk deleted the rm-3.7 branch June 6, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant