Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌪️➰ Evaluation loop and filter triples #1214

Merged
merged 18 commits into from
Jan 31, 2023
Merged

🌪️➰ Evaluation loop and filter triples #1214

merged 18 commits into from
Jan 31, 2023
+43 −2

Conversation

mberr
Copy link
Member

@mberr mberr commented Jan 28, 2023

Fix #1213

mberr and others added 12 commits January 28, 2023 12:36
@mberr
forward additional_filter_triples
6bc89ca
@mberr
re-use type hint
f05788b
@mberr
fix import

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fdc57a9
@mberr
reformat

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f529e23
@mberr
add smoke-test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bb181d6
@mberr
fix smoketest
a6459d9
@mberr
fix import order
5b327b1
@mberr
update setup.cfg to explicitly include typing_extensions
082fd0a 
it has already been included recursively via the torch requirement
@mberr
remove unused import
67c7242
@cthoyt
Merge branch 'master' into evaluation-loop-and-filter-triples
80ef5a5
@cthoyt
Update evaluation_loop.py
7114610
@cthoyt
Shorten
4fb59cc
cthoyt
cthoyt reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! are we actually using the evaluation loop in practice yet, though? I thought the pipeline hadn't switched over to relying on this yet, so does this actually address how potentially old code is working?

@mberr mberr mentioned this pull request Jan 28, 2023
Merged
2 tasks
@mberr mberr changed the title Evaluation loop and filter triples 🌪️➰ Evaluation loop and filter triples Jan 30, 2023
@mberr mberr marked this pull request as ready for review January 30, 2023 20:07
@cthoyt cthoyt enabled auto-merge (squash) January 31, 2023 20:39
@cthoyt cthoyt disabled auto-merge January 31, 2023 21:34
@cthoyt cthoyt merged commit 015c833 into master Jan 31, 2023
@cthoyt cthoyt deleted the evaluation-loop-and-filter-triples branch January 31, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EvaluationLoopCallback does not allow to pass additional_filter_triples
2 participants
@mberr @cthoyt