Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new lexer request: mediawiki #827

Closed
Anteru opened this issue Aug 31, 2019 · 11 comments
Closed

new lexer request: mediawiki #827

Anteru opened this issue Aug 31, 2019 · 11 comments
Labels
S-major severity: major T-feature type: a new feature X-imported imported from Bitbucket
Milestone

Comments

@Anteru
Copy link
Collaborator

Anteru commented Aug 31, 2019

(Original issue 1120 created by None on 2015-06-25T00:48:23.593066+00:00)

See also:

https://github.com/textmate/mediawiki.tmbundle

https://gerrit.wikimedia.org/r/#/c/213964/3/geshi/geshi/mediawiki.php

@Anteru Anteru added T-feature type: a new feature X-imported imported from Bitbucket S-major severity: major labels Aug 31, 2019
@Anteru
Copy link
Collaborator Author

Anteru commented Aug 31, 2019

(Original comment by sseb35 on 2018-02-21T13:52:25.715751+00:00)

I began working on it and I have a first "Work in Progress"; I just need some time to publish it, I didn’t used hg since a long time and I don’t know how BitBucket works in details.

@ghost
Copy link

ghost commented Jun 17, 2020

Does it have the extensive feature set of these two files?

Note only the second file is very good at handling template parameter/argument values, which allow any nested wikitext.

Mediawiki is VERY complex stuff and I salute you if you've made progress

@Artoria2e5
Copy link

It's also going to need an HTML part. Subclassing under HTML might be a good idea.

@Kenny2github
Copy link
Contributor

Mediawiki is VERY complex stuff

At least this is just lexing, rather than parsing - parsers run into problems when templates are involved, e.g. what happens when Template:Bold contains the text ''' and then you have '''bold{{bold}}?
Whereas all the lexer has to do is emit ''', bold, {{, bold, }}

@edg2s
Copy link

edg2s commented Jan 3, 2021

We are trying to phase out templates that output unbalanced syntax. They should be pretty rare and it would be an acceptable failing edge case for a highlighter IMO.

Downstream issue: https://phabricator.wikimedia.org/T29828

@NovemLinguae
Copy link

Does it have the extensive feature set of these two files?

Note only the second file is very good at handling template parameter/argument values, which allow any nested wikitext.

Mediawiki is VERY complex stuff and I salute you if you've made progress

The second link died. Here's an updated link.

(Original comment by sseb35 on 2018-02-21T13:52:25.715751+00:00)

I began working on it and I have a first "Work in Progress"; I just need some time to publish it, I didn’t used hg since a long time and I don’t know how BitBucket works in details.

@Anteru You mention a "work in progress". Is there a way to publish what you have somewhere and link it here?

@Anteru
Copy link
Collaborator Author

Anteru commented Aug 22, 2022

@NovemLinguae That's an imported issue from back when we used Bitbucket originally by sseb35. During the conversion everything got attributed to me :) I don't have anything work-in-progress, and unless you can track down who sseb35 there's no way to find out what it was.

@jhsoby
Copy link

jhsoby commented Sep 5, 2022

@NovemLinguae That's an imported issue from back when we used Bitbucket originally by sseb35. During the conversion everything got attributed to me :) I don't have anything work-in-progress, and unless you can track down who sseb35 there's no way to find out what it was.

I'm pretty sure sseb35 is @Seb35 – a familiar name in wiki circles.

@diskdance
Copy link
Contributor

@diskdance
Copy link
Contributor

3 months of work. Hope it is useful! :)

@diskdance
Copy link
Contributor

@jeanas This issue can be closed now.

@jeanas jeanas closed this as completed Apr 5, 2023
@Anteru Anteru added this to the 2.15.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-major severity: major T-feature type: a new feature X-imported imported from Bitbucket
Projects
None yet
Development

No branches or pull requests

8 participants