Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to NestedText v3 #2459

Merged
merged 5 commits into from
Jun 26, 2023
Merged

update to NestedText v3 #2459

merged 5 commits into from
Jun 26, 2023

Conversation

KenKundert
Copy link
Contributor

This change update pygments support for NestedText from version 1.0 to version 3.0.

pygments/lexers/configs.py Outdated Show resolved Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
@jeanas
Copy link
Contributor

jeanas commented Jun 24, 2023

Please also add some tests for the new functionality.

@KenKundert
Copy link
Contributor Author

Thanks for your suggestions. They were very helpful. I think the overall result is much improved. I am done with my changes and I believe the pull request is now read to go.

Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks. Still a few things to fix though.

pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
@KenKundert
Copy link
Contributor Author

I believe all the issues are now resolved.

@jeanas jeanas merged commit a1091c7 into pygments:master Jun 26, 2023
15 checks passed
@jeanas
Copy link
Contributor

jeanas commented Jun 26, 2023

Thank you!

@KenKundert
Copy link
Contributor Author

Thank you very much. I appreciate all of your help and patience.

@Anteru Anteru added this to the 2.16.0 milestone Aug 5, 2023
@Anteru Anteru added the A-lexing area: changes to individual lexers label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lexing area: changes to individual lexers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants