Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CMake bracket comment syntax #2354

Merged
merged 1 commit into from Feb 24, 2023
Merged

Implement CMake bracket comment syntax #2354

merged 1 commit into from Feb 24, 2023

Conversation

rvanvelzen
Copy link
Contributor

Closes #2338

birkenfeld
birkenfeld reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good except for a small question.

pygments/lexers/make.py Outdated Show resolved Hide resolved
@birkenfeld birkenfeld merged commit 0b8fed9 into pygments:master Feb 24, 2023
@birkenfeld
Copy link
Member

Thanks!

@birkenfeld birkenfeld added the changelog-update Items which need to get mentioned in the changelog label Feb 24, 2023
@rvanvelzen rvanvelzen deleted the cmake-bracket-comment branch February 24, 2023 13:36
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Mar 25, 2023
@Anteru Anteru added this to the 2.15.0 milestone Mar 25, 2023
@Anteru Anteru added the A-lexing area: changes to individual lexers label Mar 25, 2023
@petwu petwu mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld left review comments

Assignees
No one assigned
Labels
A-lexing area: changes to individual lexers
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Add support for CMake bracket comment
3 participants
@rvanvelzen @birkenfeld @Anteru